martinzink commented on a change in pull request #1152: URL: https://github.com/apache/nifi-minifi-cpp/pull/1152#discussion_r834166935
########## File path: extensions/procfs/processors/ProcFsMonitor.cpp ########## @@ -0,0 +1,282 @@ +/** + * @file GenerateFlowFile.cpp + * GenerateFlowFile class implementation + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include "ProcFsMonitor.h" +#include <limits> +#include <utility> +#include <vector> +#include <unordered_map> + +#include "core/Resource.h" +#include "core/ProcessContext.h" +#include "core/ProcessSession.h" +#include "../ProcFsJsonSerialization.h" +#include "utils/JsonCallback.h" +#include "utils/OpenTelemetryLogDataModelUtils.h" +#include "utils/gsl.h" + +using namespace std::literals::chrono_literals; + +namespace org::apache::nifi::minifi::extensions::procfs { + +const core::Relationship ProcFsMonitor::Success("success", "All files are routed to success"); + +const core::Property ProcFsMonitor::OutputFormatProperty( + core::PropertyBuilder::createProperty("Output Format")-> + withDescription("The output type of the new flowfile")-> + withAllowableValues<std::string>(OutputFormat::values())-> + withDefaultValue(toString(OutputFormat::JSON))->build()); + +const core::Property ProcFsMonitor::OutputCompactnessProperty( + core::PropertyBuilder::createProperty("Output Compactness")-> + withDescription("The output format of the new flowfile")-> + withAllowableValues<std::string>(OutputCompactness::values())-> + withDefaultValue(toString(OutputCompactness::PRETTY))->build()); + +const core::Property ProcFsMonitor::DecimalPlaces( + core::PropertyBuilder::createProperty("Round to decimal places")-> + withDescription("The number of decimal places to round the values to (blank for no rounding)")->build()); + +const core::Property ProcFsMonitor::ResultRelativenessProperty( + core::PropertyBuilder::createProperty("Result Type")-> + withDescription("Absolute returns the current procfs values, relative calculates the usage between triggers")-> + withAllowableValues<std::string>(ResultRelativeness::values())-> + withDefaultValue(toString(ResultRelativeness::RELATIVE))->build()); + + +void ProcFsMonitor::initialize() { + setSupportedProperties({OutputFormatProperty, OutputCompactnessProperty, DecimalPlaces, ResultRelativenessProperty}); + setSupportedRelationships({ProcFsMonitor::Success}); +} + +void ProcFsMonitor::onSchedule(const std::shared_ptr<core::ProcessContext>& context, const std::shared_ptr<core::ProcessSessionFactory>&) { + gsl_Expects(context); + context->getProperty(OutputFormatProperty.getName(), output_format_); + context->getProperty(OutputCompactnessProperty.getName(), output_compactness_); + context->getProperty(ResultRelativenessProperty.getName(), result_relativeness_); + setupDecimalPlacesFromProperties(*context); +} + +namespace { +size_t number_of_cores(const std::unordered_map<std::string, CpuStatData>& cpu_stat) { + return cpu_stat.size() > 1 ? cpu_stat.size() - 1 : 1; +} + +bool cpu_stats_are_valid(const std::unordered_map<std::string, CpuStatData>& cpu_stat) { + return cpu_stat.contains("cpu") && cpu_stat.size() > 1; // needs the aggregate and at least one core information to be valid +} + +std::optional<std::chrono::duration<double>> getAggregateCpuDiff(std::unordered_map<std::string, CpuStatData>& current_cpu_stats, + std::unordered_map<std::string, CpuStatData>& last_cpu_stats) { + if (current_cpu_stats.size() != last_cpu_stats.size()) + return std::nullopt; + if (!cpu_stats_are_valid(current_cpu_stats) || !cpu_stats_are_valid(last_cpu_stats)) + return std::nullopt; + + return (current_cpu_stats.at("cpu").getTotal()-last_cpu_stats.at("cpu").getTotal()) / number_of_cores(current_cpu_stats); +} +} // namespace + +void ProcFsMonitor::onTrigger(core::ProcessContext*, core::ProcessSession* session) { + gsl_Expects(session); + std::shared_ptr<core::FlowFile> flowFile = session->create(); + if (!flowFile) { + logger_->log_error("Failed to create flowfile!"); + yield(); + return; + } + + rapidjson::Document root = rapidjson::Document(rapidjson::kObjectType); + rapidjson::Value &body = prepareJSONBody(root); + auto current_cpu_stats = proc_fs_.getCpuStats(); + auto current_disk_stats = proc_fs_.getDiskStats(); + auto current_net_devs = proc_fs_.getNetDevs(); + auto current_process_stats = proc_fs_.getProcessStats(); + + auto last_cpu_period = getAggregateCpuDiff(current_cpu_stats, last_cpu_stats_); + + auto refresh_members = gsl::finally([&]{ refreshMembers(std::move(current_cpu_stats), + std::move(current_disk_stats), + std::move(current_net_devs), + std::move(current_process_stats));}); + + processCPUInformation(current_cpu_stats, body, root.GetAllocator()); + processDiskInformation(current_disk_stats, body, root.GetAllocator()); + processNetworkInformation(current_net_devs, body, root.GetAllocator()); + processProcessInformation(current_process_stats, last_cpu_period, body, root.GetAllocator()); + processMemoryInformation(body, root.GetAllocator()); + + if (output_compactness_ == OutputCompactness::PRETTY) { + utils::PrettyJsonOutputCallback callback(std::move(root), decimal_places_); + session->write(flowFile, &callback); + session->transfer(flowFile, Success); + } else if (output_compactness_ == OutputCompactness::COMPACT) { + utils::JsonOutputCallback callback(std::move(root), decimal_places_); + session->write(flowFile, &callback); + session->transfer(flowFile, Success); + } else { + throw Exception(GENERAL_EXCEPTION, "Invalid output compactness"); + } +} + +rapidjson::Value& ProcFsMonitor::prepareJSONBody(rapidjson::Document& root) { + if (output_format_ == OutputFormat::OPENTELEMETRY) { + utils::OpenTelemetryLogDataModel::appendEventInformation(root, "PerformanceData"); + utils::OpenTelemetryLogDataModel::appendHostInformation(root); + utils::OpenTelemetryLogDataModel::appendBody(root); + return root["Body"]; + } else if (output_format_ == OutputFormat::JSON) { + return root; + } else { + throw Exception(GENERAL_EXCEPTION, "Invalid output format"); + } +} + +void ProcFsMonitor::setupDecimalPlacesFromProperties(const core::ProcessContext& context) { + std::string decimal_places_str; + if (!context.getProperty(DecimalPlaces.getName(), decimal_places_str) || decimal_places_str.empty()) { + decimal_places_ = std::nullopt; + return; + } + + if (auto decimal_places = context.getProperty<int64_t>(DecimalPlaces)) { + if (*decimal_places > std::numeric_limits<uint8_t>::max()) + throw Exception(PROCESS_SCHEDULE_EXCEPTION, "ProcFsMonitor Decimal Places is out of range"); + decimal_places_ = *decimal_places; + } + if (decimal_places_) + logger_->log_trace("Rounding is enabled with %d decimal places", decimal_places_.value()); Review comment: reworked this part in https://github.com/apache/nifi-minifi-cpp/commit/491d4746d43fcf6da3f82d4e1b0708aab89c44b2#diff-d776bd6998730fd9d2699bfd677cabc117092a8692c9b1a73392e7ba5310a529R160-R169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
