exceptionfactory commented on a change in pull request #5885:
URL: https://github.com/apache/nifi/pull/5885#discussion_r835529311
##########
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestListSFTP.java
##########
@@ -74,12 +82,14 @@ public void setUp() throws Exception {
@After
public void tearDown() throws Exception {
sshServer.stopServer();
+ Files.deleteIfExists(Paths.get(sshServer.getVirtualFileSystemPath()));
}
@Test
- public void testRunFileFound() {
+ public void testRunFileFound() throws InterruptedException {
+ writeTempFile(1);
+ Thread.sleep(STABILITY_WAIT);
Review comment:
Thanks for the update. Running multiple iterations might work, although
that seems questionable.
Since the listing strategy handling is not part of `ListSFTP` itself, it
seems like these tests would be better run in the context of the class that
implements the logic. Not sure if that just shifts the problem to a different
location, but it might be worth considering.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
