Github user bbende commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1156#discussion_r86825589
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-services/nifi-hbase-client-service-api/src/main/java/org/apache/nifi/hbase/HBaseClientService.java
 ---
    @@ -67,6 +67,14 @@
                 .defaultValue("1")
                 .build();
     
    +    PropertyDescriptor PHOENIX_CLIENT_JAR_LOCATION = new 
PropertyDescriptor.Builder()
    +            .name("Phoenix Client JAR Location")
    +            .description("The full path to the Phoenix client JAR. 
Required if Phoenix is installed on top of HBase.")
    +            .addValidator(StandardValidators.FILE_EXISTS_VALIDATOR)
    +            .expressionLanguageSupported(true)
    +            .dynamicallyModifiesClasspath(true)
    --- End diff --
    
    Yes what you described is correct... by "use this capability" I meant the 
following...
    - Determine if the given component needs copying of resources, if so apply 
@RequiresInstanceClassLoading
    - Modify the property descriptor to use dynamicallyModifiesClasspath(true)
    - Remove any code in the component that does anything with the ClassLoader


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to