lordgamez commented on a change in pull request #1286:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1286#discussion_r836176504
##########
File path: docker/test/integration/minifi/core/NifiContainer.py
##########
@@ -54,11 +55,12 @@ def deploy(self):
logging.info('Creating and running nifi docker container...')
self.__create_config()
self.client.containers.run(
- self.image_store.get_image(self.get_engine()),
+ "apache/nifi:" + NifiContainer.NIFI_VERSION,
Review comment:
This change was on purpose as the newest image declares the config
directory as `VOLUME` so it cannot be changed in build only in runtime which is
done that way now. Because of this there is no need to do anything in build
time we can use the docker image as it is. Not all containers need a changed
base image, for example the Azure image is done this way too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
