MikeThomsen commented on a change in pull request #5909:
URL: https://github.com/apache/nifi/pull/5909#discussion_r836916173
##########
File path:
nifi-nar-bundles/nifi-enrich-bundle/nifi-enrich-processors/src/main/java/org/apache/nifi/processors/GeoEnrichIPRecord.java
##########
@@ -102,14 +102,6 @@
.addValidator(StandardValidators.NON_EMPTY_EL_VALIDATOR)
.expressionLanguageSupported(ExpressionLanguageScope.FLOWFILE_ATTRIBUTES)
.build();
- public static final PropertyDescriptor GEO_ACCURACY = new
PropertyDescriptor.Builder()
Review comment:
I did a Github search through the Maxmind GeoIp2-Java repo, and it looks
like `accuracy` is no longer a field on their response objects. So this
wouldn't actually return anything if left in place. It's not a required field,
so it shouldn't break anything, but in this case I feel like it might be better
to stop the flow until someone looks at it than to let them proceed wondering
where the heck the accuracy part went.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
