greyp9 commented on pull request #5890:
URL: https://github.com/apache/nifi/pull/5890#issuecomment-1083207205
> Thanks for addressing this issue @greyp9. It seems like this change should
cover the particular issue, but it also looks like the `ScheduledState` has the
following additional values that may need to be considered:
>
> * STARTING
> * STOPPING
> * RUN_ONCE
>
> I'm also not sure whether the previous scheduled state of `STOPPED` always
implies the `RunOnce` operation. That seems to be the case in common operation.
Do you think those other states should be considered as part of this change?
Hmm. It's true these additional values are not considered. My testing
zeroed in on the "Run Once" case, and this change was sufficient to address
it. Maybe we could revisit if we encounter a different case in the future?
Another option would be to add an `} else {`, but not sure if that makes
things clearer, as there isn't an `enum Operation` that would be appropriate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
