markap14 edited a comment on pull request #5696: URL: https://github.com/apache/nifi/pull/5696#issuecomment-1084879658
Thanks for the updates @simonbence! I noted what I think is a typo. Otherwise, I think all of my concerns have been addressed. I will want to do some testing to verify behavior but in terms of code review, things look good. I did notice one new file, though, that was empty: `nifi-nar-bundles/nifi-framework-bundle/nifi-framework-external-resource-utils/src/test/resources/resource.json` - given that it's an empty file and it's under `src/test/resources` it may well be intended to be there but just wanted to make sure. There were also some updates to `pom.xml` files that reference `1.16.0-SNAPSHOT` that I think need to be updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
