[ 
https://issues.apache.org/jira/browse/NIFI-2778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15645216#comment-15645216
 ] 

ASF GitHub Bot commented on NIFI-2778:
--------------------------------------

Github user mattyb149 commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1138#discussion_r86852784
  
    --- Diff: 
nifi-commons/nifi-data-provenance-utils/src/main/java/org/apache/nifi/provenance/AsyncQuerySubmission.java
 ---
    @@ -82,4 +90,8 @@ public Query getQuery() {
         public StandardQueryResult getResult() {
             return queryResult;
         }
    +
    +    public void addQueryExecution(Future<?> execution) {
    --- End diff --
    
    Is this method only on AsyncQuerySubmission (versus the parent interface) 
because adding an execution only applies to async queries? I figure it is but 
wanted to make sure. If other implementations would benefit from this method, 
it might be better as an default interface method on the parent that throws a 
MethodNotSupported or something. But if it really only applies in this setting, 
I'm fine with that too.


> If a Provenance Query is canceled, the repository doesn't stop immediately
> --------------------------------------------------------------------------
>
>                 Key: NIFI-2778
>                 URL: https://issues.apache.org/jira/browse/NIFI-2778
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>            Reporter: Mark Payne
>            Assignee: Oleg Zhurakousky
>             Fix For: 1.1.0
>
>
> When a Provenance Query is issued and then canceled, the result object is 
> marked as canceled, but repository continues to search. It should instead 
> stop querying lucene and stop reading events from the provenance log files



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to