exceptionfactory opened a new pull request, #5962:
URL: https://github.com/apache/nifi/pull/5962
#### Description of PR
NIFI-9901 Adds the `nifi-xml-processing` module to `nifi-commons` and
refactors XML handling to use common components.
Components in `nifi-xml-processing` replace the usage of `XmlUtils` in
`nifi-security-utils` with interfaces and implementation classes specific to
each type of XML processing. The module includes the following interfaces
derived from standard Java XML components:
- `DocumentProvider` for DOM Documents
- `InputSourceParser` for SAX Parsing
- `XMLEventReaderProvider` and `XMLStreamReaderProvider` for StAX Parsing
- `SchemaValidator` for XML Schema Validation
The `nifi-xml-processing` Maven configuration includes
`spotbugs-maven-plugin` with `findsecbugs-plugin` to analyze components for XML
processing vulnerabilities during the build.
General changes include refactoring references to
`javax.xml.parsers.DocumentBuilderFactory` and
`javax.xml.stream.XMLInputFactory` throughout the system to use
`nifi-xml-processing` components.
Specific changes include updates to the `EvaluateXPath` and `EvaluateXQuery`
Processors to disable Document Type Declaration Validation in the default
configuration. Other adjustments include relocating Apache Commons
Configuration 2 classes to `nifi-lookup-services`, which is the only reference
to those components. This relocation allows `nifi-xml-processing` to avoid any
external dependencies.
As a result of this refactoring, `nifi-security-utils` no longer contains
any XML processing components, which allows some referencing modules to avoid
unnecessary transitive dependencies.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [X] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
