lordgamez commented on code in PR #1294:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1294#discussion_r849461803
##########
docker/test/integration/resources/syslog-client/tcp/Dockerfile:
##########
@@ -0,0 +1,2 @@
+FROM ubuntu:latest
Review Comment:
Please use a specific version instead of latest as the latest tag could
refer to another version later.
##########
docker/test/integration/minifi/core/ImageStore.py:
##########
@@ -181,6 +185,12 @@ def __build_mqtt_broker_image(self):
def __build_splunk_image(self):
return self.__build_image_by_path(self.test_dir +
"/resources/splunk-hec", 'minifi-splunk')
+ def __build_syslog_udp_client_image(self):
+ return self.__build_image_by_path(self.test_dir +
"/resources/syslog-client/udp", 'syslog-udp-client')
+
+ def __build_syslog_tcp_client_image(self):
+ return self.__build_image_by_path(self.test_dir +
"/resources/syslog-client/tcp", 'syslog-tcp-client')
Review Comment:
Do these need to be built as new images? Looking at the Dockerfiles it seems
to me that we could use the ubuntu image and define the entrypoint parameter
with the command in the image. This way we could remove the images, and have
only 1 container with 2 different commands for TCP and UDP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
