martinzink commented on code in PR #1294:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1294#discussion_r849588662
##########
docker/test/integration/minifi/core/ImageStore.py:
##########
@@ -181,6 +185,12 @@ def __build_mqtt_broker_image(self):
def __build_splunk_image(self):
return self.__build_image_by_path(self.test_dir +
"/resources/splunk-hec", 'minifi-splunk')
+ def __build_syslog_udp_client_image(self):
+ return self.__build_image_by_path(self.test_dir +
"/resources/syslog-client/udp", 'syslog-udp-client')
+
+ def __build_syslog_tcp_client_image(self):
+ return self.__build_image_by_path(self.test_dir +
"/resources/syslog-client/tcp", 'syslog-tcp-client')
Review Comment:
Good idea. I've changed this in
https://github.com/apache/nifi-minifi-cpp/pull/1294/commits/26053fde5f0a6d4ed055ee98558d9653fd89254a
##########
docker/test/integration/resources/syslog-client/tcp/Dockerfile:
##########
@@ -0,0 +1,2 @@
+FROM ubuntu:latest
Review Comment:
Good idea. I've changed this in
https://github.com/apache/nifi-minifi-cpp/pull/1294/commits/26053fde5f0a6d4ed055ee98558d9653fd89254a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
