exceptionfactory opened a new pull request, #5972:
URL: https://github.com/apache/nifi/pull/5972
#### Description of PR
NIFI-9883 Refactors the process of loading Sensitive Property Providers to
use an isolated `ClassLoader`.
These changes impact the loading process for `nifi.properties`,
`authorizers.xml`, and `login-identity-providers.xml`. The classes responsible
for loading these configuration files include updates to set the current Thread
context `ClassLoader` during the loading operation, and reset the previous
`ClassLoader` after completion.
The implementation moves runtime dependencies for Sensitive Property
Provider implementations to a new `lib/properties` directory as part of the
standard NiFi binary installation. A new `PropertyProtectionURLClassLoader`
attempts to read the files located in `lib/properties`, making libraries
available for runtime processing of encrypted properties.
This approach reduces the size the `nifi-framework-nar` and several other
NAR binaries through sharing JAR files located in `lib/properties`. These
changes also avoid introducing unexpected runtime changes due to transitive
dependencies required for Sensitive Property Provider implementations.
Additional changes include streamlined unit tests for NiFi properties that
reduce duplication of encryption property handling.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X] Does your PR title start with **NIFI-XXXX** where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X] Has your PR been rebased against the latest commit within the target
branch (typically `main`)?
- [X] Is your initial contribution a single, squashed commit? _Additional
commits in response to PR reviewer feedback should be made on this branch and
pushed to allow change tracking. Do not `squash` or use `--force` when pushing
to allow for clean monitoring of changes._
### For code changes:
- [X] Have you ensured that the full suite of tests is executed via `mvn
-Pcontrib-check clean install` at the root `nifi` folder?
- [X] Have you written or updated unit tests to verify your changes?
- [X] Have you verified that the full build is successful on JDK 8?
- [ ] Have you verified that the full build is successful on JDK 11?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE` file, including the main
`LICENSE` file under `nifi-assembly`?
- [ ] If applicable, have you updated the `NOTICE` file, including the main
`NOTICE` file found under `nifi-assembly`?
- [ ] If adding new Properties, have you added `.displayName` in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which
it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI for
build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
