adamdebreceni commented on code in PR #1304:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1304#discussion_r854112625


##########
extensions/librdkafka/PublishKafka.cpp:
##########
@@ -602,7 +602,13 @@ bool PublishKafka::configureNewConnection(const 
std::shared_ptr<core::ProcessCon
     }
   }
   value = "";
-  if (context->getProperty(QueueBufferMaxMessage.getName(), value) && 
!value.empty()) {
+  uint32_t int_val;
+  if (context->getProperty(QueueBufferMaxMessage.getName(), int_val)) {
+    if (int_val < batch_size_) {
+      throw Exception(PROCESS_SCHEDULE_EXCEPTION, "Invalid configuration: 
Batch Size cannot be larger than Queue Max Message");

Review Comment:
   were we able to trigger the expected problematic behavior?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to