szaszm commented on code in PR #1311:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1311#discussion_r854287928
##########
extensions/standard-processors/processors/GetFile.cpp:
##########
@@ -234,15 +235,15 @@ bool GetFile::fileMatchesRequestCriteria(std::string
fullName, std::string name,
#ifdef WIN32
struct _stat64 statbuf;
- if (_stat64(fullName.c_str(), &statbuf) != 0) {
- return false;
- }
+ const auto stat_result = _stat64(fullName.c_str(), &statbuf);
Review Comment:
We certainly can. Updated in
[4671175](https://github.com/apache/nifi-minifi-cpp/pull/1311/commits/467117511fee9b25413a0091f2cb66c579e8ecb0)
std::filesystem::last_write_time is a bit problematic because of the
file_clock, but used utils::file::last_write_time instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
