markap14 commented on PR #5925: URL: https://github.com/apache/nifi/pull/5925#issuecomment-1104248945
Thanks @turcsanyip . That's a good catch. We can't really add the classes found in .class files because we don't know what the fully qualified class name is. We do know if it's found in a .jar or a .jmod file. Good news is that it doesn't really matter, as it's only used to detect classes that are part of Java itself, and Java packages all of their classes uses the appropriate packing mechanisms (.jmod / .jar) - at least in every case I've found. Hard to imagine that they wouldn't. So I removed the .class from the list of things we add to the 'loadable files'. I think this is fine and addresses the mismatch between the two. I also rebased as there was a conflict with main. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
