fgerlits commented on code in PR #1309:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1309#discussion_r859802494
##########
libminifi/include/utils/StringUtils.h:
##########
@@ -495,6 +495,15 @@ class StringUtils {
static std::string escapeUnprintableBytes(gsl::span<const std::byte> data);
+ /**
+ * Returns whether sequence of patterns are found in given string in their
incoming order
+ * Non-regex search!
+ * @param str string to search in
+ * @param patterns sequence of patterns to search
+ * @return success of string sequence matching
+ */
+ static bool matchesSequence(const std::string_view str, const
std::vector<std::string>& patterns);
Review Comment:
nitpicking, but `const` is unnecessary in the header for by-value parameters
##########
libminifi/include/utils/ThreadPool.h:
##########
@@ -340,6 +337,10 @@ class ThreadPool {
std::recursive_mutex manager_mutex_;
// thread pool name
std::string name_;
+ // count of running tasks by ID
+ std::unordered_map<TaskId, unsigned> running_task_count_by_id_;
Review Comment:
is there a reason to use `unsigned` here? types with a well-defined size
like `uint32_t` are generally better
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
