lordgamez commented on code in PR #1320:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1320#discussion_r861545182
##########
extensions/http-curl/tests/AbsoluteTimeoutTest.cpp:
##########
@@ -22,20 +22,14 @@
#include "tests/TestServer.h"
#include "HTTPHandlers.h"
+using namespace std::literals::chrono_literals;
+
int main() {
TestController controller;
std::string port = "12324";
std::string rootURI = "/";
- TimeoutingHTTPHandler handler({
- std::chrono::milliseconds(500),
- std::chrono::milliseconds(500),
- std::chrono::milliseconds(500),
- std::chrono::milliseconds(500),
- std::chrono::milliseconds(500),
- std::chrono::milliseconds(500),
- std::chrono::milliseconds(500)
- });
+ TimeoutingHTTPHandler handler({35, 100ms});
Review Comment:
You are right, it's more explicit and clear this way, updated in
8497f10ca144a7d8053d83ae67c24942168e4540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
