Github user jtstorck commented on a diff in the pull request:

    https://github.com/apache/nifi/pull/1190#discussion_r87228856
  
    --- Diff: 
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestTailFile.java
 ---
    @@ -620,6 +620,27 @@ public void testMultipleFiles() throws IOException, 
InterruptedException {
             
runner.getFlowFilesForRelationship(TailFile.REL_SUCCESS).get(4).assertContentEquals("1\n");
         }
     
    +    @Test
    +    public void testMultipleFilesWithBasedirAndFilenameEL() throws 
IOException, InterruptedException {
    +        runner.setVariable("vrBaseDirectory", "target");
    +        runner.setProperty(TailFile.BASE_DIRECTORY, "${vrBaseDirectory}");
    +        runner.setProperty(TailFile.MODE, TailFile.MODE_MULTIFILE);
    +        runner.setVariable("vrFilename", "(testDir/)?log(ging)?.txt");
    +        runner.setProperty(TailFile.FILENAME, "${vrFilename}");
    +        runner.setProperty(TailFile.ROLLING_FILENAME_PATTERN, 
"${filename}.?");
    +        runner.setProperty(TailFile.START_POSITION, 
TailFile.START_CURRENT_FILE);
    +        runner.setProperty(TailFile.RECURSIVE, "true");
    +
    +        runner.run(1);
    +        runner.assertAllFlowFilesTransferred(TailFile.REL_SUCCESS, 0);
    +
    +        otherRaf.write("hi\n".getBytes());
    --- End diff --
    
    I can make that change, but being that it's just a test for reading from 
the file and the test does not care about the actual output or verify the data 
read from the file (its just to get TailFile to read some data from the file to 
show that the processor is resolving the EL) is it really necessary?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to