adamdebreceni commented on code in PR #1310:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1310#discussion_r872170800
##########
libminifi/src/utils/file/FileUtils.cpp:
##########
@@ -49,41 +52,23 @@ uint64_t computeChecksum(const std::string &file_name,
uint64_t up_to_position)
}
bool contains(const std::filesystem::path& file_path, std::string_view
text_to_search) {
- gsl_Expects(text_to_search.size() <= 8192);
+ gsl_Expects(text_to_search.size() <= 8_KiB);
gsl_ExpectsAudit(std::filesystem::exists(file_path));
- std::array<char, 8192> buf1{};
- std::array<char, 8192> buf2{};
- gsl::span<char> left = buf1;
- gsl::span<char> right = buf2;
-
- const auto charat = [&](size_t idx) {
- if (idx < left.size()) {
- return left[idx];
- } else if (idx < left.size() + right.size()) {
- return right[idx - left.size()];
- } else {
- return '\0';
- }
- };
- const auto check_range = [&](size_t start, size_t end) -> size_t {
- for (size_t i = start; i < end; ++i) {
- size_t j{};
- for (j = 0; j < text_to_search.size(); ++j) {
- if (charat(i + j) != text_to_search[j]) break;
- }
- if (j == text_to_search.size()) return true;
- }
- return false;
- };
+ std::array<char, 16_KiB> buf{};
+ gsl::span<char> view;
Review Comment:
it is not yet used in our codebase, if there is no technical reason behind
this, I think we should dedicate a separate PR to replace all `gsl::span` with
`std::span`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
