martinzink commented on code in PR #1297:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1297#discussion_r874720119


##########
PROCESSORS.md:
##########
@@ -390,6 +393,42 @@ In the list below, the names of required properties appear 
in bold. Any other pr
 |failure|If file deletion from Azure Data Lake storage fails the flowfile is 
transferred to this relationship|
 |success|If file deletion from Azure Data Lake storage succeeds the flowfile 
is transferred to this relationship|
 
+## DeleteGCSObject
+
+### Description
+
+Deletes an object from a Google Cloud Bucket.
+
+### Properties
+
+In the list below, the names of required properties appear in bold. Any other 
properties (not in bold) are considered optional. The table also indicates any 
default values, and whether a property supports the NiFi Expression Language.
+
+| Name                                 | Default Value | Allowable Values      
                                                            | Description       
                                                                                
                               |
+|--------------------------------------|---------------|-----------------------------------------------------------------------------------|----------------------------------------------------------------------------------------------------------------------------------|
+| **Bucket**                           | ${gcs.bucket} |                       
                                                            | Bucket of the 
object.<br>**Supports Expression Language: true**                               
                                   |
+| **Key**                              | ${filename}   |                       
                                                            | Name of the 
object.<br>**Supports Expression Language: true**                               
                                     |
+| **Number Of retries**                | 6             | integers              
                                                            | How many retry 
attempts should be made before routing to the failure relationship.             
                                  |
+| **GCP Credentials Provider Service** |               | 
[GCPCredentialsControllerService](CONTROLLERS.md#GCPCredentialsControllerService)
 | The Controller Service used to obtain Google Cloud Platform credentials.     
                                                    |
+| Server Side Encryption Key           |               |                       
                                                            | An AES256 
Encryption Key (encoded in base64) for server-side encryption of the 
object.<br>**Supports Expression Language: true** |
+| Generation                           |               |                       
                                                            | The generation of 
the Object to download. If null, will download latest generation.               
                               |
+| Endpoint Override URL                |               |                       
                                                            | Overrides the 
default Google Cloud Storage endpoints                                          
                                   |

Review Comment:
   I copied the pattern from the AWS, and Azure processors. e.g. 
https://github.com/apache/nifi-minifi-cpp/blob/main/extensions/aws/processors/S3Processor.cpp#L84
 
   
   I can change it, but we would need to check if not setting the endpoint and 
setting it to the official endpoint works in the same way in every situation. I 
didnt check this yet but can do if you'd like.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to