exceptionfactory commented on code in PR #5990:
URL: https://github.com/apache/nifi/pull/5990#discussion_r874954702
##########
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/utils/AzureStorageUtils.java:
##########
@@ -311,4 +316,34 @@ public static void setProxy(final OperationContext
operationContext, final Proce
final ProxyConfiguration proxyConfig =
ProxyConfiguration.getConfiguration(processContext);
operationContext.setProxy(proxyConfig.createProxy());
}
+
+ public static void configureProxy(final NettyAsyncHttpClientBuilder
nettyClientBuilder, final PropertyContext propertyContext) {
Review Comment:
That's a good point @turcsanyip, I agree that it would be better to decouple
this utility method from the Netty Client implementation. This PR does couple
the components to the Netty implementation, where previously the implementation
was loaded based on available libraries. Not sure of other impacts, but
something to consider.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
