szaszm commented on code in PR #1332: URL: https://github.com/apache/nifi-minifi-cpp/pull/1332#discussion_r877257128
########## extensions/http-curl/tests/C2UpdateAssetTest.cpp: ########## @@ -0,0 +1,260 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#undef NDEBUG +#include <vector> +#include <string> +#include <fstream> +#include <iterator> + +#include "HTTPIntegrationBase.h" +#include "HTTPHandlers.h" +#include "utils/IntegrationTestUtils.h" +#include "utils/Environment.h" + +class FileProvider : public ServerAwareHandler { + public: + explicit FileProvider(std::string file_content): file_content_(std::move(file_content)) {} + + bool handleGet(CivetServer* /*server*/, struct mg_connection* conn) override { + mg_printf(conn, "HTTP/1.1 200 OK\r\nContent-Type: " + "text/plain\r\nContent-Length: %lu\r\nConnection: close\r\n\r\n", + file_content_.length()); + mg_printf(conn, "%s", file_content_.c_str()); + return true; + } + + private: + std::string file_content_; +}; + +class C2HeartbeatHandler : public HeartbeatHandler { + public: + using HeartbeatHandler::HeartbeatHandler; + + bool handlePost(CivetServer* /*server*/, struct mg_connection* conn) override { + std::lock_guard<std::mutex> guard(op_mtx_); + sendHeartbeatResponse(operations_, conn); + operations_.clear(); + return true; + } + + void addOperation(std::string id, std::unordered_map<std::string, std::string> args) { + std::lock_guard<std::mutex> guard(op_mtx_); + operations_.push_back(C2Operation{ + .operation = "update", + .operand = "asset", + .operation_id = std::move(id), + .args = std::move(args) + }); + } + + private: + std::mutex op_mtx_; + std::vector<C2Operation> operations_; +}; + +class VerifyC2AssetUpdate : public VerifyC2Base { + public: + void configureC2() override { + configuration->set("nifi.c2.agent.protocol.class", "RESTSender"); + configuration->set("nifi.c2.enable", "true"); + configuration->set("nifi.c2.agent.heartbeat.period", "100"); Review Comment: I was thinking that if `produce` adds a new heartbeat every 100ms, and `consume` consumes one every 100ms, then it might be possible that `responses.size()` stay > 0 long term, and `consume` gains N * 100ms latency. Or at least that's what I thought, but I couldn't trigger any issues now, so I'm probably misremembering some detail. Feel free to ignore this. I don't think it would be an issue in this case anyway. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
