exceptionfactory commented on code in PR #6057:
URL: https://github.com/apache/nifi/pull/6057#discussion_r877414967
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/audit/ControllerServiceAuditor.java:
##########
@@ -144,13 +148,13 @@ public Object
updateControllerServiceAdvice(ProceedingJoinPoint proceedingJoinPo
// create a configuration action accordingly
if (operation != null) {
// clear the value if this property is sensitive
- final PropertyDescriptor propertyDescriptor =
controllerService.getControllerServiceImplementation().getPropertyDescriptor(property);
- if (propertyDescriptor != null &&
propertyDescriptor.isSensitive()) {
+ final PropertyDescriptor propertyDescriptor =
controllerService.getPropertyDescriptor(property);
+ if (propertyDescriptor != null &&
(propertyDescriptor.isSensitive() ||
sensitiveDynamicPropertyNames.contains(property))) {
Review Comment:
Good point, will add a comment on the reasoning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
