fgerlits commented on code in PR #1337:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1337#discussion_r879184928
##########
extensions/expression-language/tests/ProcessContextExprTests.cpp:
##########
@@ -31,8 +31,14 @@ namespace org::apache::nifi::minifi {
class DummyProcessor : public core::Processor {
public:
using core::Processor::Processor;
- EXTENSIONAPI static core::Property SimpleProperty;
- EXTENSIONAPI static core::Property ExpressionLanguageProperty;
+#ifdef WIN32
+ __declspec(dllexport)
+#endif
+ static core::Property SimpleProperty;
+#ifdef WIN32
+ __declspec(dllexport)
+#endif
+ static core::Property ExpressionLanguageProperty;
Review Comment:
Are those `dllexport`s necessary? Since tests are generally linked
statically together with the minifi code and not loaded dynamically, I would
expect this to work:
```suggestion
static core::Property SimpleProperty;
static core::Property ExpressionLanguageProperty;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
