exceptionfactory commented on code in PR #6073:
URL: https://github.com/apache/nifi/pull/6073#discussion_r881990223
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/jquery/propertytable/jquery.propertytable.js:
##########
@@ -2115,32 +2143,36 @@
var row = propertyData.getRowById(id);
propertyGrid.setActiveCell(row,
propertyGrid.getColumnIndex('value'));
propertyGrid.editActiveCell();
- });
- } else {
- // if this row is currently hidden, clear
the value and show it
- if (existingItem.hidden === true) {
-
propertyData.updateItem(existingItem.id, $.extend(existingItem, {
- hidden: false,
- previousValue: null,
- value: null
- }));
-
- // select the new properties row
- var row =
propertyData.getRowById(existingItem.id);
- propertyGrid.setActiveCell(row,
propertyGrid.getColumnIndex('value'));
- propertyGrid.editActiveCell();
} else {
- nfDialog.showOkDialog({
- headerText: 'Property Exists',
- dialogContent: 'A property with
this name already exists.'
- });
-
- // select the existing properties row
- var row =
propertyData.getRowById(existingItem.id);
- propertyGrid.setSelectedRows([row]);
- propertyGrid.scrollRowIntoView(row);
+ // if this row is currently hidden,
clear the value and show it
+ if (existingItem.hidden === true) {
+
propertyData.updateItem(existingItem.id, $.extend(existingItem, {
+ hidden: false,
+ previousValue: null,
+ value: null
+ }));
+
+ // select the new properties row
+ var row =
propertyData.getRowById(existingItem.id);
+ propertyGrid.setActiveCell(row,
propertyGrid.getColumnIndex('value'));
+ propertyGrid.editActiveCell();
+ propertyGrid.invalidateRow(row);
+ propertyGrid.render();
Review Comment:
Thanks for catching that issue, invalidating the row is necessary for the
value formatter to evaluate the updated sensitive status, reordering the calls
works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
