[
https://issues.apache.org/jira/browse/NIFI-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15654762#comment-15654762
]
ASF GitHub Bot commented on NIFI-2890:
--------------------------------------
GitHub user jskora opened a pull request:
https://github.com/apache/nifi/pull/1201
NIFI-2890 Provenance Repository Corruption
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [X ] Does your PR title start with NIFI-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [X ] Has your PR been rebased against the latest commit within the target
branch (typically master)?
- [X ] Is your initial contribution a single, squashed commit?
### For code changes:
- [X ] Have you ensured that the full suite of tests is executed via mvn
-Pcontrib-check clean install at the root nifi folder?
- [X ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main
LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main
NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to
.name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
Correct handling of corrupt journal file that was preventing instance
startup and causing loss of records from uncorrupt files.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jskora/nifi NIFI-2890-1.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1201.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1201
----
commit d89d5f684e1ea19b74167a03c6b987e161fceab1
Author: Joe Skora <[email protected]>
Date: 2016-11-10T18:06:41Z
NIFI-2890 Provenance Repository Corruption - Correct handling of corrupt
journal file that was preventing instance startup and causing loss of records
from uncorrupt files.
----
> Provenance Repository corruption
> --------------------------------
>
> Key: NIFI-2890
> URL: https://issues.apache.org/jira/browse/NIFI-2890
> Project: Apache NiFi
> Issue Type: Bug
> Affects Versions: 1.0.0, 0.7.0
> Reporter: Brandon DeVries
> Assignee: Joe Skora
>
> It looks as thought there was a ticket to address this\[1\], but it appears
> to not have completely addressed the issue. On an 0.6.1 instance (that
> crashed hard), I'm getting a stack trace on startup indicating a corrupt prov
> repo. The relevant part of the stack trace (unfortunately typed by hand, so
> forgive the inevitable typos) is:
> {quote}
> ...
> Caused By java.lang.IllegalArgumentException: No enum constant
> org.apahe.nifi.provenance.ProvenenceEventType.
> at java.lang/.Enum.valueOf...
> at
> org.apache.nifi.provenance.ProvenanaceEventType.valueOf(ProvenanaceEventType.java:19)
> at
> org.apache.nifi.provenance.StandardRecordReader.nextRecord(StandardRecordReader.java:284)
> at
> org.apache.nifi.provenance.PersistentProvenanceRepository.mergeJournals(PersistentProvenanceRepository.java:1678)
> \[2\]
> ...
> {quote}
> In 0.x HEAD, this appears to have moved a bit\[3\]. Same is true for
> 1.x\[4\]. In both 0.x\[5\] and 1.x\[6\], code was added to check for "bad"
> records coming from the reader, and skip them. However, this appears to only
> address the issue if the corrupt / bad record is the *first* record coming
> out of a reader. If it is a subsequent record, the corruption remains.
> \[1\] https://issues.apache.org/jira/browse/NIFI-803
> \[2\]
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[3\]
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1711
> \[4\]
> https://github.com/apache/nifi/blob/rel/nifi-0.6.1/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1678
> \[5\]
> https://github.com/apache/nifi/blob/0.x/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1564-L1578
> \[6\]
> https://github.com/apache/nifi/blob/master/nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/src/main/java/org/apache/nifi/provenance/PersistentProvenanceRepository.java#L1658-L1672
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
