gresockj commented on code in PR #6138:
URL: https://github.com/apache/nifi/pull/6138#discussion_r901882428
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-components/src/main/java/org/apache/nifi/flow/synchronization/StandardVersionedComponentSynchronizer.java:
##########
@@ -1433,6 +1433,14 @@ public void synchronize(final ParameterContext
parameterContext, final Versioned
} else {
final Map<String, Parameter> updatedParameters =
createParameterMap(proposed.getParameters());
+ // If any parameters are removed, need to add a null value
to the map in order to make sure that the parameter is removed.
Review Comment:
It looks like this is also a problem in `synchronize(final ProcessGroup
group, final VersionedProcessGroup proposed, final Map<String,
VersionedParameterContext> versionedParameterContexts)`, which is the code path
used to synchronize a versioned group. What do you think about adding similar
logic at line 1962?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
