exceptionfactory commented on code in PR #5905:
URL: https://github.com/apache/nifi/pull/5905#discussion_r905038747
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java:
##########
@@ -70,6 +70,33 @@
public static final Set<Relationship> relationships =
Collections.unmodifiableSet(
new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
+ private static final Set<String> units = Collections.unmodifiableSet(
+ new HashSet<>(Arrays.asList(
+ "Seconds", "Microseconds", "Milliseconds", "Bytes",
+ "Kilobytes", "Megabytes", "Gigabytes", "Terabytes",
+ "Bits", "Kilobits", "Megabits", "Gigabits", "Terabits",
+ "Percent", "Count", "Bytes/Second", "Kilobytes/Second",
+ "Megabytes/Second", "Gigabytes/Second", "Terabytes/Second",
+ "Bits/Second", "Kilobits/Second", "Megabits/Second",
+ "Gigabits/Second", "Terabits/Second", "Count/Second",
+ "None", "")));
Review Comment:
Following up on this discussion, it seems better to check for an empty
string separately from the list of allowed types. Taking another look at this,
do the valid values exist anywhere in the AWS SDK? It seems like this list
could become difficult to maintain.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
