szaszm commented on code in PR #1340:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1340#discussion_r905305999
##########
libminifi/include/properties/Configuration.h:
##########
@@ -156,12 +156,17 @@ class Configuration : public Properties {
static constexpr const char *nifi_asset_directory = "nifi.asset.directory";
+ // Metrics publisher options
+ static constexpr const char *nifi_metrics_publisher_class =
"nifi.metrics.publisher.class";
+ static constexpr const char
*nifi_metrics_publisher_prometheus_metrics_publisher_port =
"nifi.metrics.publisher.PrometheusMetricsPublisher.port";
Review Comment:
Fair point. Let's leave it as is, and maybe think about it later, if it
starts to become a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]