patalwell commented on code in PR #5905:
URL: https://github.com/apache/nifi/pull/5905#discussion_r905562979
##########
nifi-nar-bundles/nifi-aws-bundle/nifi-aws-processors/src/main/java/org/apache/nifi/processors/aws/cloudwatch/PutCloudWatchMetric.java:
##########
@@ -70,6 +70,33 @@
public static final Set<Relationship> relationships =
Collections.unmodifiableSet(
new HashSet<>(Arrays.asList(REL_SUCCESS, REL_FAILURE)));
+ private static final Set<String> units = Collections.unmodifiableSet(
+ new HashSet<>(Arrays.asList(
+ "Seconds", "Microseconds", "Milliseconds", "Bytes",
+ "Kilobytes", "Megabytes", "Gigabytes", "Terabytes",
+ "Bits", "Kilobits", "Megabits", "Gigabits", "Terabits",
+ "Percent", "Count", "Bytes/Second", "Kilobytes/Second",
+ "Megabytes/Second", "Gigabytes/Second", "Terabytes/Second",
+ "Bits/Second", "Kilobits/Second", "Megabits/Second",
+ "Gigabits/Second", "Terabits/Second", "Count/Second",
+ "None", "")));
Review Comment:
It's a java enum ->
https://sdk.amazonaws.com/java/api/latest/software/amazon/awssdk/services/cloudwatch/model/StandardUnit.html
we could potentially leverage the SDK and call the types from the
software.amazon.awssdk.services.cloudwatch.model package to prevent breaking
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
