timeabarna commented on code in PR #6115:
URL: https://github.com/apache/nifi/pull/6115#discussion_r905761611


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core-api/src/main/java/org/apache/nifi/controller/AbstractComponentNode.java:
##########
@@ -1084,12 +1092,29 @@ public void onParametersModified(final Map<String, 
ParameterUpdate> updatedParam
         }
 
         // If this component is affected by the Parameter change, we need to 
re-validate
+        componentAffected |= 
isConfigurationParameterModified(updatedParameters);
         if (componentAffected) {
             logger.debug("Configuration of {} changed due to an update to 
Parameter Context. Resetting validation state", this);
             resetValidationState();
         }
     }
 
+    protected void increaseReferenceCounts(final String parameterName) {
+        parameterReferenceCounts.merge(parameterName, 1, (a, b) -> a == -1 ? 
null : a + b);
+    }
+
+    protected void decreaseReferenceCounts(final String parameterName) {
+        parameterReferenceCounts.merge(parameterName, -1, (a, b) -> a == 1 ? 
null : a + b);
+    }
+
+    /**
+     * Verifies whether any referenced configuration parameter has been 
updated and its effective value has changed.
+     * If yes, the component needs to be re-validated.
+     * @param updatedParameters updated parameters
+     * @return true if the component requires re-validation

Review Comment:
   Due to refactor this method has been removed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to