bejancsaba commented on code in PR #6149: URL: https://github.com/apache/nifi/pull/6149#discussion_r906717346
########## c2/c2-client-bundle/c2-client-service/src/test/java/org/apache/nifi/c2/client/service/operation/UpdateConfigurationOperationHandlerTest.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.c2.client.service.operation; + +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.nifi.c2.client.service.operation.UpdateConfigurationOperationHandler.LOCATION; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.when; + +import java.util.Collections; +import java.util.Map; +import java.util.Optional; +import java.util.function.Function; +import org.apache.nifi.c2.client.api.C2Client; +import org.apache.nifi.c2.client.service.FlowIdHolder; +import org.apache.nifi.c2.protocol.api.C2Operation; +import org.apache.nifi.c2.protocol.api.C2OperationAck; +import org.apache.nifi.c2.protocol.api.C2OperationState; +import org.apache.nifi.c2.protocol.api.OperandType; +import org.apache.nifi.c2.protocol.api.OperationType; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; + +@ExtendWith(MockitoExtension.class) +public class UpdateConfigurationOperationHandlerTest { + + private static final String FLOW_ID = "flowId"; + private static final String OPERATION_ID = "operationId"; + private static final Map<String, String> CORRECT_LOCATION_MAP = Collections.singletonMap(LOCATION, "/path/for/the/" + FLOW_ID); + private static final Map<String, String> INCORRECT_LOCATION_MAP = Collections.singletonMap(LOCATION, "incorrect/location"); + + @Mock + private C2Client client; + + @Mock + private FlowIdHolder flowIdHolder; + + @Test + void testUpdateConfigurationOperationHandlerCreateSuccess() { + UpdateConfigurationOperationHandler handler = new UpdateConfigurationOperationHandler(null, null, null); + + assertEquals(OperationType.UPDATE, handler.getOperationType()); + assertEquals(OperandType.CONFIGURATION, handler.getOperandType()); + } + + @Test + void testHandleThrowsExceptionForIncorrectArg() { + UpdateConfigurationOperationHandler handler = new UpdateConfigurationOperationHandler(null, null, null); + C2Operation operation = new C2Operation(); + operation.setArgs(INCORRECT_LOCATION_MAP); + + IllegalStateException exception = assertThrows(IllegalStateException.class, () -> handler.handle(operation)); + + assertEquals("Could not get flow id from the provided URL", exception.getMessage()); + } + + @Test + void testHandleReturnsNotAppliedWithNoContent() { + when(flowIdHolder.getFlowId()).thenReturn("dummy"); + when(client.retrieveUpdateContent(any())).thenReturn(Optional.empty()); + UpdateConfigurationOperationHandler handler = new UpdateConfigurationOperationHandler(client, flowIdHolder, null); + C2Operation operation = new C2Operation(); + operation.setArgs(CORRECT_LOCATION_MAP); + + C2OperationAck response = handler.handle(operation); + + assertEquals(EMPTY, response.getOperationId()); + assertEquals(C2OperationState.OperationState.NOT_APPLIED, response.getOperationState().getState()); + } + + @Test + void testHandleReturnsNotAppliedWithContentApplyIssues() { + Function<byte[], Boolean> failedToUpdate = x -> false; + when(flowIdHolder.getFlowId()).thenReturn("dummy"); Review Comment: applied ########## c2/c2-client-bundle/c2-client-service/src/test/java/org/apache/nifi/c2/client/service/operation/UpdateConfigurationOperationHandlerTest.java: ########## @@ -0,0 +1,121 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.nifi.c2.client.service.operation; + +import static org.apache.commons.lang3.StringUtils.EMPTY; +import static org.apache.nifi.c2.client.service.operation.UpdateConfigurationOperationHandler.LOCATION; +import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertThrows; +import static org.mockito.ArgumentMatchers.any; +import static org.mockito.Mockito.when; + +import java.util.Collections; +import java.util.Map; +import java.util.Optional; +import java.util.function.Function; +import org.apache.nifi.c2.client.api.C2Client; +import org.apache.nifi.c2.client.service.FlowIdHolder; +import org.apache.nifi.c2.protocol.api.C2Operation; +import org.apache.nifi.c2.protocol.api.C2OperationAck; +import org.apache.nifi.c2.protocol.api.C2OperationState; +import org.apache.nifi.c2.protocol.api.OperandType; +import org.apache.nifi.c2.protocol.api.OperationType; +import org.junit.jupiter.api.Test; +import org.junit.jupiter.api.extension.ExtendWith; +import org.mockito.Mock; +import org.mockito.junit.jupiter.MockitoExtension; + +@ExtendWith(MockitoExtension.class) +public class UpdateConfigurationOperationHandlerTest { + + private static final String FLOW_ID = "flowId"; + private static final String OPERATION_ID = "operationId"; + private static final Map<String, String> CORRECT_LOCATION_MAP = Collections.singletonMap(LOCATION, "/path/for/the/" + FLOW_ID); + private static final Map<String, String> INCORRECT_LOCATION_MAP = Collections.singletonMap(LOCATION, "incorrect/location"); + + @Mock + private C2Client client; + + @Mock + private FlowIdHolder flowIdHolder; + + @Test + void testUpdateConfigurationOperationHandlerCreateSuccess() { + UpdateConfigurationOperationHandler handler = new UpdateConfigurationOperationHandler(null, null, null); + + assertEquals(OperationType.UPDATE, handler.getOperationType()); + assertEquals(OperandType.CONFIGURATION, handler.getOperandType()); + } + + @Test + void testHandleThrowsExceptionForIncorrectArg() { + UpdateConfigurationOperationHandler handler = new UpdateConfigurationOperationHandler(null, null, null); + C2Operation operation = new C2Operation(); + operation.setArgs(INCORRECT_LOCATION_MAP); + + IllegalStateException exception = assertThrows(IllegalStateException.class, () -> handler.handle(operation)); + + assertEquals("Could not get flow id from the provided URL", exception.getMessage()); + } + + @Test + void testHandleReturnsNotAppliedWithNoContent() { + when(flowIdHolder.getFlowId()).thenReturn("dummy"); + when(client.retrieveUpdateContent(any())).thenReturn(Optional.empty()); + UpdateConfigurationOperationHandler handler = new UpdateConfigurationOperationHandler(client, flowIdHolder, null); + C2Operation operation = new C2Operation(); + operation.setArgs(CORRECT_LOCATION_MAP); + + C2OperationAck response = handler.handle(operation); + + assertEquals(EMPTY, response.getOperationId()); + assertEquals(C2OperationState.OperationState.NOT_APPLIED, response.getOperationState().getState()); + } + + @Test + void testHandleReturnsNotAppliedWithContentApplyIssues() { + Function<byte[], Boolean> failedToUpdate = x -> false; + when(flowIdHolder.getFlowId()).thenReturn("dummy"); + when(client.retrieveUpdateContent(any())).thenReturn(Optional.of("content".getBytes())); + UpdateConfigurationOperationHandler handler = new UpdateConfigurationOperationHandler(client, flowIdHolder, failedToUpdate); + C2Operation operation = new C2Operation(); + operation.setIdentifier(OPERATION_ID); + operation.setArgs(CORRECT_LOCATION_MAP); + + C2OperationAck response = handler.handle(operation); + + assertEquals(OPERATION_ID, response.getOperationId()); + assertEquals(C2OperationState.OperationState.NOT_APPLIED, response.getOperationState().getState()); + } + + @Test + void testHandleReturnsFullyApplied() { + Function<byte[], Boolean> successUpdate = x -> true; + when(flowIdHolder.getFlowId()).thenReturn("dummy"); Review Comment: applied -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
