adamdebreceni commented on code in PR #1340:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1340#discussion_r907461728
##########
libminifi/include/core/state/nodes/MetricsBase.h:
##########
@@ -108,27 +104,33 @@ class ObjectNode : public ResponseNode {
nodes_.push_back(node);
}
- virtual std::string getName() const {
+ const std::vector<std::shared_ptr<ResponseNode>>& get_child_nodes() const {
Review Comment:
I see that the casing is mixed in this class, IMO we should go with
camelCase for new methods
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
