kevdoran commented on PR #6155: URL: https://github.com/apache/nifi/pull/6155#issuecomment-1170272091
Thanks for the review and feedback @exceptionfactory! This is a good idea, and given the limited usage of this implementation, excluding it from the convenience binary makes sense. I've moved the implementation to its own NAR now and here are the new testing instructions: ``` # Build full project # Copy the new nifi-rocksdb-nar to the assembly lib dir: > cp nifi-nar-bundles/nifi-rocksdb-bundle/nifi-rocksdb-nar/target/nifi-rocksdb-nar-1.17.0-SNAPSHOT.nar nifi-assembly/target/nifi-1.17.0-SNAPSHOT-bin/nifi-1.17.0-SNAPSHOT/lib # Edit the assembly nifi.properties to have the following: nifi.flowfile.repository.implementation=org.apache.nifi.controller.repository.RocksDBFlowFileRepository # Start NiFi and verify it works as expected > ./nifi-assembly/target/nifi-1.17.0-SNAPSHOT-bin/nifi-1.17.0-SNAPSHOT/bin/nifi.sh run ``` This is still failing at runtime when using those steps, so I need to fix something 🙂 @joewitt - This PR will update the Administration Guide appropriately, and I've added a note to the JIRA about the need for special migration guidance -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
