steven-matison commented on code in PR #61:
URL: https://github.com/apache/nifi-site/pull/61#discussion_r917867428
##########
layouts/_default/baseof.html:
##########
@@ -0,0 +1,36 @@
+<!DOCTYPE html>
+
+<html class="no-js" lang="en">
+ <head>
+ <title>{{ .Title }}</title>
+ <meta charset="utf-8" />
+ <meta name="viewport" content="width=device-width, initial-scale=1.0"
/>
+ <link rel="shortcut icon" href="/assets/images/nifi16.ico"/>
+ <link rel="stylesheet" href="/assets/stylesheets/app.css" />
+ <link rel="stylesheet" href="/assets/stylesheets/font-awesome.min.css">
+ <script src="/assets/js/modernizr.js"></script>
+ <script src="/assets/js/webfontloader.js"></script>
Review Comment:
Js Versions:
`/assets/js/modernizr.js` Modernizr v2.8.3
`/assets/js/webfontloader.js` Web Font Loader v1.5.21
`/assets/js/jquery.min.js` jQuery v2.1.4
`/assets/js/foundation.js` Foundation Responsive Library *
http://foundation.zurb.com. (no version)
`/assets/js/app.js` this may not be needed in new site ???
@exceptionfactory is there a cdn host preferred? Here are the above
which I found from cdnjs.com:
https://cdnjs.cloudflare.com/ajax/libs/modernizr/2.8.3/modernizr.min.js
https://cdnjs.cloudflare.com/ajax/libs/webfont/1.5.21/webfontloader.js
https://cdnjs.cloudflare.com/ajax/libs/jquery/2.1.4/jquery.min.js
https://cdnjs.cloudflare.com/ajax/libs/foundation/6.7.4/js/foundation.min.js
(this is the current version, not sure of the version on the site now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
