adamdebreceni commented on code in PR #1328: URL: https://github.com/apache/nifi-minifi-cpp/pull/1328#discussion_r918878788
########## libminifi/include/core/ThreadedRepository.h: ########## @@ -0,0 +1,86 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <thread> + +#include "Repository.h" +#include "TraceableResource.h" + +namespace org::apache::nifi::minifi::core { + +class ThreadedRepository : public core::Repository, public core::TraceableResource { + public: + using Repository::Repository; + + ~ThreadedRepository() override { + if (running_.load()) { + logger_->log_error("Thread of %s should have been stopped in subclass before ThreadedRepository's destruction", name_); + } + } + + // Starts repository monitor thread + void start() { + if (running_.exchange(true)) { + return; + } + if (purge_period_ <= std::chrono::milliseconds(0)) { + return; + } + getThread() = std::thread(&ThreadedRepository::run, this); Review Comment: I don't think there is such a restriction, `&ThreadedRepository::run` is a pointer to member function which, together with the `this`, seem to be a suitable arguments for the `std::thread` constructor, the behind the scenes magic (most likely offset into the vtable) makes sure that when called the overridden method based on the objects dynamic type is called -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
