szaszm commented on code in PR #1328: URL: https://github.com/apache/nifi-minifi-cpp/pull/1328#discussion_r919232606
########## libminifi/include/core/ThreadedRepository.h: ########## @@ -0,0 +1,86 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#pragma once + +#include <memory> +#include <thread> + +#include "Repository.h" +#include "TraceableResource.h" + +namespace org::apache::nifi::minifi::core { + +class ThreadedRepository : public core::Repository, public core::TraceableResource { + public: + using Repository::Repository; + + ~ThreadedRepository() override { + if (running_.load()) { + logger_->log_error("Thread of %s should have been stopped in subclass before ThreadedRepository's destruction", name_); + } + } + + // Starts repository monitor thread + void start() { + if (running_.exchange(true)) { + return; + } + if (purge_period_ <= std::chrono::milliseconds(0)) { + return; + } + getThread() = std::thread(&ThreadedRepository::run, this); Review Comment: You're right. I didn't find anything in the standard that disallows this, and the member function pointer explanation in [this article](https://www.codeproject.com/Articles/7150/Member-Function-Pointers-and-the-Fastest-Possible) suggests that they keep track internally whether it's virtual or non-virtual and single or multiple inheritance. I'd still replace it with a lambda, simply because that looks simpler to me, but it's OK as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
