Github user markap14 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1208#discussion_r87630105
--- Diff:
nifi-commons/nifi-site-to-site-client/src/main/java/org/apache/nifi/remote/client/SiteToSiteClient.java
---
@@ -560,7 +560,8 @@ public SiteToSiteClient build() {
}
/**
- * @return the configured URL for the remote NiFi instance
+ * @return the configured URL for the remote NiFi instance.
+ * The URL string possibly contains multiple URL entries in
comma-separated format.
*/
public String getUrl() {
--- End diff --
This is concerning to me. This may be a breaking change for some, as it
previously returned a String that was a valid URI or URL. It may not be
anymore. I would rather see this return only the first URL, and have an
additional method added: `List<String> getUrls();`
Thoughts?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
