lordgamez commented on code in PR #1354:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1354#discussion_r926468331
##########
main/AgentDocs.h:
##########
@@ -26,7 +26,7 @@ class AgentDocs {
public:
void generate(const std::string &docsdir, std::ostream &genStream);
private:
- [[nodiscard]] inline std::string extractClassName(const std::string
&processor) const;
+ [[nodiscard]] static inline std::string extractClassName(const std::string
&processor);
Review Comment:
Updated in d3b1db61b23d80b28385fde5f77af73c4661b95a
##########
libminifi/src/core/Processor.cpp:
##########
@@ -304,18 +303,13 @@ bool Processor::isThrottledByBackpressure() const {
}
return false;
})();
Review Comment:
Good idea, updated in d3b1db61b23d80b28385fde5f77af73c4661b95a
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
