[
https://issues.apache.org/jira/browse/NIFI-10234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17570905#comment-17570905
]
David Handermann commented on NIFI-10234:
-----------------------------------------
Thanks for summarizing the implementation approach [~xuanronaldo], this is very
helpful and well-defined! Writing up these details provides a great opportunity
to work through a few questions prior to the implementation, so thanks for
taking the time to put this together.
The general approach looks good, just a few questions and comments:
*Naming and Properties*
1. As a general rule for NiFi extensions, components should not end with the
word {{Processor}}, so shortening the name to {{PutIoTDB}} would be good
2. Since the context of the property configuration is already {{IoTDB}},
shortening the first two properties to {{Host}} and {{Port}} should be clear
enough
3. The {{Host}} and {{Port}} properties should be required. Although having
{{6667}} as the default port makes sense given the IoTDB documentation, it is
unlikely that IoTDB will be running on the same host as NiFi, so recommend
avoiding a default value for the {{Host}} property
4. Although the IoTDB documentation indicates that {{root}} is the default
username and password, it would be best to avoid setting these default values
in NiFi
*Schema and Records*
Instead of requiring each Record and Record Schema to have a field named
{{Time}}, it would be much better to make the time field a configurable
property. Recommend naming this something like {{Time Field}}.
The rest of the details make sense at this point, and additional details can be
worked out in the pull review process.
Thanks again for summarizing the planned implementation!
> implement a processor of Apache IoTDB
> -------------------------------------
>
> Key: NIFI-10234
> URL: https://issues.apache.org/jira/browse/NIFI-10234
> Project: Apache NiFi
> Issue Type: New Feature
> Components: Extensions
> Reporter: Xuan Ronaldo
> Priority: Major
>
> Hi, folks
>
> I'm a contributer of Apache IoTDB. Recently, I have implemented a processor
> which can write data to IoTDB. I'd like to submit it to the NiFi as a
> build-in processor. Besides, there are more processors or controller services
> will be developed.
>
> Regards,
> Xuan Ronaldo
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
