adamdebreceni commented on code in PR #1038:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1038#discussion_r930797790
##########
extensions/rocksdb-repos/FlowFileRepository.h:
##########
@@ -203,6 +205,24 @@ class FlowFileRepository : public core::Repository {
running_ = true;
thread_ = std::thread(&FlowFileRepository::run, this);
logger_->log_debug("%s Repository Monitor Thread Start", getName());
+ swap_loader.start();
+ }
+
+ void stop() override {
+ swap_loader.stop();
+ core::Repository::stop();
+ }
+
+ void store(std::vector<std::shared_ptr<core::FlowFile>> flow_files) override
{
+ for (auto& flow_file : flow_files) {
+ if (!flow_file->isStored()) {
+ throw Exception(FLOW_EXCEPTION, "A flow file that is being swapped out
is not stored in the flow repository");
+ }
+ }
Review Comment:
added `gsl_Expects`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
