exceptionfactory commented on code in PR #6227:
URL: https://github.com/apache/nifi/pull/6227#discussion_r931195188
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/serialization/VersionedFlowSynchronizer.java:
##########
@@ -384,7 +384,6 @@ private void synchronizeFlow(final FlowController
controller, final DataFlow exi
private FlowComparison compareFlows(final DataFlow existingFlow, final
DataFlow proposedFlow, final PropertyEncryptor encryptor) {
final DifferenceDescriptor differenceDescriptor = new
StaticDifferenceDescriptor();
-
Review Comment:
This change can be reverted
##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/test/resources/conf/new-flow.json:
##########
@@ -0,0 +1 @@
+{"encodingVersion":{"majorVersion":2,"minorVersion":0},"maxTimerDrivenThreadCount":10,"registries":[],"parameterContexts":[],"controllerServices":[],"reportingTasks":[],"templates":[],"rootGroup":{"identifier":"2a2b649d-8538-3239-9965-536b5b993cc5","instanceIdentifier":"13c477b8-0182-1000-31df-454d42e70446","name":"NiFi
Flow","comments":"","position":{"x":0.0,"y":0.0},"processGroups":[],"remoteProcessGroups":[],"processors":[],"inputPorts":[],"outputPorts":[],"connections":[],"labels":[],"funnels":[],"controllerServices":[],"variables":{},"defaultFlowFileExpiration":"0
sec","defaultBackPressureObjectThreshold":10000,"defaultBackPressureDataSizeThreshold":"1
GB","flowFileOutboundPolicy":"STREAM_WHEN_AVAILABLE","flowFileConcurrency":"UNBOUNDED","componentType":"PROCESS_GROUP"}}
Review Comment:
It would be helpful to pretty-print these JSON flow definitions to make them
easier to read for testing. Alternatively, is it possible to construct the flow
definitions in test methods instead of external files?
##########
nifi-registry/nifi-registry-core/nifi-registry-flow-diff/src/main/java/org/apache/nifi/registry/flow/diff/StandardFlowComparator.java:
##########
@@ -129,7 +129,7 @@ private boolean compareComponents(final VersionedComponent
componentA, final Ver
}
private boolean compareComponents(final VersionedComponent componentA,
final VersionedComponent componentB, final Set<FlowDifference> differences,
- final boolean compareName, final boolean comparePos, final boolean
compareComments) {
+ final boolean compareName, final boolean
comparePos, final boolean compareComments) {
Review Comment:
The changes in this file appear to be limited to formatting, can you revert
the changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
