markap14 commented on code in PR #6131:
URL: https://github.com/apache/nifi/pull/6131#discussion_r931354937
##########
nifi-nar-bundles/nifi-kafka-bundle/nifi-kafka-2-6-processors/src/main/java/org/apache/nifi/processors/kafka/pubsub/PublishKafkaRecord_2_6.java:
##########
@@ -239,6 +251,7 @@ public class PublishKafkaRecord_2_6 extends
AbstractProcessor implements Verifia
+ "If not specified, no FlowFile attributes will be added as
headers.")
.addValidator(StandardValidators.REGULAR_EXPRESSION_VALIDATOR)
.expressionLanguageSupported(NONE)
+ .dependsOn(PUBLISH_STRATEGY, PUBLISH_USE_VALUE)
Review Comment:
I'm not sure that it's necessary here. In the case of the Consumer, we are
passing it down the stack (or "up the stack?") so that the lease knows what to
do with it. Here, it doesn't look like we're passing the Publish Strategy to
any other classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
