xuanronaldo commented on PR #6265: URL: https://github.com/apache/nifi/pull/6265#issuecomment-1207801918
> Thanks for making the initial changes @xuanronaldo. > > I took a closer look at the implementation and noted a number of areas for improvement. The division of the abstract class and concrete class is helpful to indicate the core functionality. The core logic in `onTrigger` was difficult to follow at points because of the layout and nesting, so some general refactoring would be helpful. Thanks for your suggestions. I will update the code asap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
