adamdebreceni commented on code in PR #1367:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1367#discussion_r940177967
##########
libminifi/include/utils/TimeUtil.h:
##########
@@ -70,6 +72,16 @@ class Clock {
public:
virtual ~Clock() = default;
virtual std::chrono::milliseconds timeSinceEpoch() const = 0;
+ virtual std::chrono::milliseconds wait_until(std::condition_variable& cv,
std::unique_lock<std::mutex>& lck, std::chrono::milliseconds time, const
std::function<bool()>& pred) {
Review Comment:
based on the comment above `Clock`, these classes' purpose is to be mocked,
as it is not possible to safely wait when using a `Clock` (as it might be an
instance of `ManualClock`) I think this new method has relevance to all users
of `Clock`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
