szaszm commented on code in PR #1377:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1377#discussion_r947874627
##########
libminifi/test/unit/ExpectedTest.cpp:
##########
@@ -52,7 +52,7 @@ TEST_CASE("expected map", "[expected][map]") {
{
const nonstd::expected<int, int> e = 21;
- auto ret = std::move(e) | utils::map(mul2);
+ auto ret = e | utils::map(mul2);
Review Comment:
These are meant to test utilities on rvalues. You can see the same tests
above on lvalues. Please revert these changes, except for the last one (with
NOLINT).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
