szaszm commented on code in PR #1392:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1392#discussion_r948039984
##########
extensions/script/python/PythonCreator.h:
##########
@@ -129,7 +129,8 @@ class PythonCreator : public minifi::core::CoreComponent {
return "";
}
const auto python_package_path = std::filesystem::relative(pythonscript,
basePath).parent_path();
- std::vector<std::string> path_elements{python_package_path.begin(),
python_package_path.end()};
+ std::vector<std::string> path_elements;
+ std::transform(python_package_path.begin(), python_package_path.end(),
std::back_inserter(path_elements), [](const auto& path) { return path.string();
});
Review Comment:
```suggestion
std::vector<std::string> path_elements;
path_elements.reserve(std::distance(python_package_path.begin(),
python_package_path.end()));
std::transform(python_package_path.begin(), python_package_path.end(),
std::back_inserter(path_elements), [](const auto& path) { return path.string();
});
```
##########
libminifi/include/agent/agent_version.h:
##########
@@ -18,6 +18,8 @@
#ifndef LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
#define LIBMINIFI_INCLUDE_AGENT_AGENT_VERSION_H_
+#undef COMPILER
+
Review Comment:
Why is this needed? Could you add a comment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
