fgerlits commented on code in PR #1370:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1370#discussion_r948147376
##########
extensions/standard-processors/tests/unit/ListenSyslogTests.cpp:
##########
@@ -439,12 +439,13 @@ TEST_CASE("Test ListenSyslog via TCP with SSL
connection", "[ListenSyslog]") {
SingleProcessorTestController controller{listen_syslog};
auto ssl_context_service =
controller.plan->addController("SSLContextService", "SSLContextService");
+ const auto executable_dir =
minifi::utils::file::FileUtils::get_executable_dir();
REQUIRE(controller.plan->setProperty(ssl_context_service,
controllers::SSLContextService::CACertificate.getName(),
- minifi::utils::file::FileUtils::get_executable_dir() +
"/resources/ca_cert.crt"));
+ minifi::utils::file::concat_path(executable_dir,
"resources/ca_cert.crt")));
Review Comment:
We need `concat_path` between `resources` and `ca_cert.crt`, too. Maybe
it's time for a 3-parameter (or variadic) `concat_path`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
