rliszli commented on code in PR #6281:
URL: https://github.com/apache/nifi/pull/6281#discussion_r948704835
##########
c2/c2-protocol/c2-protocol-api/pom.xml:
##########
@@ -33,5 +33,9 @@ limitations under the License.
<artifactId>c2-protocol-component-api</artifactId>
<version>1.18.0-SNAPSHOT</version>
</dependency>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>
Review Comment:
The reason behind this change is that different clients sends the orderType
values in different ways(upper or lower case). Before adding the @JsonCreatorit
annotation, I checked and it is used several places in nifi-api modules. I can
have the same result by writing a Custom Deserializer and add it to an
ObjectMapper in C2JacksonSerializer. I think it's a more complicated solution
and I don't think that there is any problem with adding the jackson dependency
to an api module. Please let me know, if you still insist to change it, I'll do
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
