turcsanyip commented on code in PR #6279:
URL: https://github.com/apache/nifi/pull/6279#discussion_r949405096
##########
nifi-nar-bundles/nifi-smb-bundle/nifi-smb-processors/src/main/java/org/apache/nifi/processors/smb/ListSmb.java:
##########
@@ -92,9 +92,8 @@
+ "given a remote location
smb://HOSTNAME:PORT/SHARE/DIRECTORY, and a file is being listen from "
+ "SHARE/DIRECTORY/sub/folder/file then the
absolute.path attribute will be set to "
+ "SHARE/DIRECTORY/sub/folder/file."),
- @WritesAttribute(attribute = "identifier", description =
- "The identifier of the file. This equals to the path attribute
so two files with the same relative path "
- + "coming from different file shares considered to be
identical."),
+ @WritesAttribute(attribute = "serviceLocation", description =
+ "The serviceLocation is set to the host and port of the remote
smb server."),
Review Comment:
The attribute contains the smb url of the share in fact, not only the
host/port.
So the following description would be more adequate:
> The SMB URL of the share.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
